Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support credentials in deploy package #743

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Support credentials in deploy package #743

merged 7 commits into from
Aug 16, 2024

Conversation

midigofrank
Copy link
Contributor

@midigofrank midigofrank commented Aug 13, 2024 •
edited by taylordowns2000
Loading

Short Description

Support the management of project credentials in via project.yaml - works with the support-credentials-in-cli-deploy branch in lightning

Implementation Details

  • When you pull, the state is updated with the project wide credentials
  • You can update the job credential by pointing it to an existing credential key
  • You can create a new project_credential if you (the apiToken user) own that credential

QA Notes

List any considerations/cases/advice for testing/QA here.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added unit tests
  • Changesets have been added (if there are production code changes)

Release branch checklist

Delete this section if this is not a release PR.

If this IS a release branch:

  • Run pnpm changeset from root to bump versions
  • Run pnpm install
  • Commit the new version numbers
  • Run pnpm changeset tag to generate tags
  • Push tags git push --tags

Tags may need updating if commits come in after the tags are first generated.

@midigofrank midigofrank self-assigned this Aug 13, 2024
@taylordowns2000 taylordowns2000 marked this pull request as ready for review August 13, 2024 15:20
@taylordowns2000 taylordowns2000 mentioned this pull request Aug 13, 2024
Merged
3 tasks
@taylordowns2000
Copy link
Member

@midigofrank , can you resolve the merge conflicts here?

i've also requested a review from @stuartc as he's likely to have some opinions 😄

josephjclark
josephjclark reviewed Aug 14, 2024
View reviewed changes
packages/deploy/src/stateTransform.ts Outdated Show resolved Hide resolved
packages/deploy/src/stateTransform.ts Outdated Show resolved Hide resolved
josephjclark
josephjclark approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested anything but happy with the code.

When you want to release, can you please follow the Release Process steps in the PR?

@taylordowns2000 taylordowns2000 merged commit ada99bf into main Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephjclark josephjclark josephjclark approved these changes

@christad92 christad92 christad92 approved these changes

@stuartc stuartc Awaiting requested review from stuartc

Assignees

@midigofrank midigofrank

Labels
None yet
Projects
v2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@midigofrank @taylordowns2000 @christad92 @josephjclark